Fix for when a client doesn't have the item #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors texture path handling to prevent nil reference errors and standardize texture path formatting across the codebase.
- Introduces a centralized
SafeTexturePathfunction that handles nil values and normalizes texture paths - Replaces inline texture path logic with calls to the new utility function
- Adds fallback handling for uncached item icons in the UI
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Core/MultiBotEngine.lua | Introduces SafeTexturePath utility function and refactors all texture path handling to use it |
| UI/MultiBotItem.lua | Adds fallback icon handling for uncached items |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Nice modification, thank you for the suggestion. I would like to suggest a few modifications. |
3 tasks
Owner
|
I fixed a few things and resolved the merge conflicts in your PR. I gave you credits, of course. |
Wishmaster117
added a commit
that referenced
this pull request
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a bots inventory the addon would error if the client does not have the icon for the item.
eg, I use this module https://github.com/silviu20092/mod-flightmaster-whistle which uses a custom item.